Postgres Pro
Downloads
Home   >   mailing lists

RE: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value. - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value.
Date
Msg-id OSCPR01MB149663B66E27A4028EC609651F5FC2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value.  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
Tree view 
Dear Sawada-san,

Thanks for updating the patch!

> I've attached the updated patch. I address all comments I got so far
> and added a small regression test.
> 
> It makes sense to me that we move GetDbnameFromConnectionOptions() to
> recovery_gen.c since this function is currently used only with
> GenerateRecoveryConfig() which is defined in the same file. If we find
> a more appropriate place, we can move it later. Feedback is very
> welcome.

I considered your idea that adding new API, but it seemed for me to have less
benefit. Also, I do not know better place for the declaration now. Overall, the
patch looks good to me.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

pgsql-hackers by date:

Previous
From: Shlok Kyal
Date:
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Next
From: Peter Smith
Date:
Subject: Re: Skip collecting decoded changes of already-aborted transactions