RE: locking [user] catalog tables vs 2pc vs logical rep - Mailing list pgsql-hackers

From osumi.takamichi@fujitsu.com
Subject RE: locking [user] catalog tables vs 2pc vs logical rep
Date
Msg-id OSBPR01MB48881128C1116D510E8765CAED319@OSBPR01MB4888.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: locking [user] catalog tables vs 2pc vs logical rep  (vignesh C <vignesh21@gmail.com>)
Responses Re: locking [user] catalog tables vs 2pc vs logical rep
Re: locking [user] catalog tables vs 2pc vs logical rep
List pgsql-hackers
On  Friday, June 11, 2021 2:13 PM  vignesh C <vignesh21@gmail.com> wrote:
> Thanks for the updated patch:
> Few comments:
> 1) We have used Reordering and Clustering for the same command, we could
> rephrase similarly in both places.
> +       <para>
> +        Reordering <structname>pg_class</structname> by
> <command>CLUSTER</command>
> +        command in a transaction.
> +       </para>
> 
> +       <para>
> +        Clustering <structname>pg_trigger</structname> and decoding
> <command>PREPARE
> +        TRANSACTION</command>, if any published table have a trigger
> and any
> +        operations that will be decoded are conducted.
> +       </para>
> +      </listitem>
> 
> 2) Here user_catalog_table should be user catalog table
> +       <para>
> +        Executing <command>TRUNCATE</command> on
> user_catalog_table
> in a transaction.
> +       </para>
Thanks for your review.

Attached the patch-set that addressed those two comments.
I also fixed the commit message a bit in the 2PC specific patch to HEAD.
No other changes.

Please check.

Best Regards,
    Takamichi Osumi


Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Fwd: BUG #17056: Segmentation fault on altering the type of the foreign table column with a default
Next
From: Bharath Rupireddy
Date:
Subject: Re: Fdw batch insert error out when set batch_size > 65535