RE: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE - Mailing list pgsql-hackers

Hi,

I find in ecpg.header, the source:
>            if (connection)
>            if (connection && strcmp(ptr->connection, connection) != 0)

The first if statement is useless. And in fix-ecpg-tests.patch:
>-            if (connection)
>-                mmerror(PARSE_ERROR, ET_WARNING, "connection %s is overwritten to %s.", connection, ptr->connection);
>+            if (connection && strcmp(ptr->connection, connection) != 0)
>+                mmerror(PARSE_ERROR, ET_WARNING, "declare statement %s using connection %s overwritten to connection
%s.",
>+                    name, connection, ptr->connection);
The patch seems right.

Delete first if statement, patch attached.

Regards,
Shenhao Wang