Fix wrong syntax about CREATE_REPLICATION_SLOT - Mailing list pgsql-hackers

From tachikake.ayaki@fujitsu.com
Subject Fix wrong syntax about CREATE_REPLICATION_SLOT
Date
Msg-id OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: Fix wrong syntax about CREATE_REPLICATION_SLOT  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

Hi hackers,

 

A minor bug was found in the "CREATE_REPLICATION_SLOT" syntax.

It is in protocol.sgml at line 1990.

 

The current syntax written in it is as follows,

 

CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL } [ ( option [, ...] ) ]

 

However, when I executed a command as follows, that became syntax error.

 

CREATE_REPLICATION_SLOT tachi LOGICAL;

ERROR:  syntax error

 

To use LOGICAL, output_plugin must be required.

Correct syntax is as follows.

 

CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL output_plugin } [ ( option [, ...] ) ]

 

PSA patch to fix it.

 

Note that version 15 must also be fixed.

 

Best Regards,

Ayaki Tachikake

FUJITSU LIMITED

 

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Next
From: Alvaro Herrera
Date:
Subject: Re: create subscription - improved warning message