RE: Confused comment about drop replica identity index - Mailing list pgsql-hackers

From wangw.fnst@fujitsu.com
Subject RE: Confused comment about drop replica identity index
Date
Msg-id OS3PR01MB62752D978D41EF6E0668AAD19E7C9@OS3PR01MB6275.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Confused comment about drop replica identity index  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Dec 20, 2021 at 19:11PM, Michael Paquier wrote:
> That's mostly fine.  I have made some adjustments as per the attached.

Thanks for reviewing.


> +         The default for non-system tables. Records the old values of the columns
> +         of the primary key, if any. The default for non-system tables.
> The same sentence is repeated twice.
>
> +         Records no information about the old row.(This is the
> default for system tables.)
> For consistency with the rest, this could drop the parenthesis for the second
> sentence.
>
> +       <term><literal>USING INDEX index_name</literal></term>
> This should use <replaceable> as markup for index_name.

The change looks good to me.



Regards,
Wang wei



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Emit a warning if the extension's GUC is set incorrectly
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Emit a warning if the extension's GUC is set incorrectly