On Mon, Apr 19, 2022 at 9:32 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Thank you for updating the patch.
Thanks for your comments.
> + * For a large transaction, if we don't send any change to the
> + downstream for a
> + * long time(exceeds the wal_receiver_timeout of standby) then it can
> timeout.
> + * This can happen when all or most of the changes are either not
> + published or
> + * got filtered out.
>
> + */
> + if(end_xact || ++changes_count >= CHANGES_THRESHOLD) {
>
> We need a whitespace before '(' at above two places. The rest looks good to me.
Fix these.
Attach the new patch.
1. Fix wrong formatting. [suggestion by Sawada-San]
Regards,
Wang wei
