On Fri, May 13, 2022 10:57 PM Osumi, Takamichi/大墨 昂道 <osumi.takamichi@fujitsu.com> wrote:
> On Friday, May 13, 2022 6:42 PM Wang, Wei/王 威 <wangw.fnst@fujitsu.com>
> wrote:
> > Attach the patches.(Only changed the patch for HEAD.).
> > 1. Optimize the code. Reduce calls to function filter_partitions.
> > [suggestions by Amit-san] 2. Improve the alias name in SQL. [suggestions by
> Amit-san] 3.
> > Improve coding alignments. [suggestions by Amit-san] 4. Do some
> > optimizations for list Concatenate.
> Hi, thank you for updating the patch.
>
>
> I have one minor comment on fetch_table_list() in HEAD v4.
Thanks for your comments.
> @@ -1759,17 +1759,22 @@ static List *
> fetch_table_list(WalReceiverConn *wrconn, List *publications) {
> WalRcvExecResult *res;
> - StringInfoData cmd;
> + StringInfoData cmd,
> + pub_names;
> TupleTableSlot *slot;
> Oid tableRow[2] = {TEXTOID, TEXTOID};
> List *tablelist = NIL;
>
> + initStringInfo(&pub_names);
> + get_publications_str(publications, &pub_names, true);
> +
>
> Kindly free the pub_names's data along with the cmd.data.
Improve it according to your suggestion. Free 'pub_names.data'.
I also made some other changes.
Kindly have a look at new patch shared in [1].
[1]
https://www.postgresql.org/message-id/OS3PR01MB6275B26B6BDF23651B8CE86D9ED19%40OS3PR01MB6275.jpnprd01.prod.outlook.com
Regards,
Wang wei
