[PATCH] support tab-completion for single quote input with equal sign - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject [PATCH] support tab-completion for single quote input with equal sign
Date
Msg-id OS0PR01MB6113F66C90164C3DAA025955FBE49@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
Responses RE: [PATCH] support tab-completion for single quote input with equal sign  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
List pgsql-hackers
Hi

I found a problem when using tab-completion as follows:

CREATE SUBSCRIPTION my_subscription
CONNECTION 'host=localhost port=5432 dbname=postgres' [TAB]

The word 'PUBLICATION' couldn't be auto completed as expected.

The reason is that the equal sign in a single quote is taken as WORD_BREAKS.
Which causes words count is not correct for a input command string.

Fix the problem in the attached patch. By fix this, "\t\n@$><=;|&{() " will not be taken as WORD_BREAKS in single
quotedinput string. 
Please be kindly to take a look at the fix and kindly to tell me if you find any scenario affected by the fix.

Regards,
Tang

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [bug?] Missed parallel safety checks, and wrong parallel safety
Next
From: Pavel Stehule
Date:
Subject: window build doesn't apply PG_CPPFLAGS correctly