On Thursday, December 2, 2021 5:21 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> PSA the v44* set of patches.
>
Thanks for the new patch. Few comments:
1. This is an example in publication doc, but in fact it's not allowed. Should we
change this example?
+CREATE PUBLICATION active_departments FOR TABLE departments WHERE (active IS TRUE);
postgres=# CREATE PUBLICATION active_departments FOR TABLE departments WHERE (active IS TRUE);
ERROR: invalid publication WHERE expression for relation "departments"
HINT: only simple expressions using columns, constants and immutable system functions are allowed
2. A typo in 0002 patch.
+ * drops such a user-defnition or if there is any other error via its function,
"user-defnition" should be "user-definition".
Regards,
Tang
