Postgres Pro
Downloads
Home   >   mailing lists

RE: Remove double check when field_name is not NULL in be-secure-openssl.c - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: Remove double check when field_name is not NULL in be-secure-openssl.c
Date
Msg-id OS0PR01MB6113A554F0DE368276D67FBFFBDB9@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Remove double check when field_name is not NULL in be-secure-openssl.c  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
On Wednesday, September 15, 2021 6:54 PM, Daniel Gustafsson <daniel@yesql.se> wrote:
>The proposal removes a second == NULL check on field_name in the case where
>OBJ_nid2sn() returns an ASN1_OBJECT.  This is not in a hot path, and the ASM
>generated is equal under optimization levels so I don't see the value in the
>code churn and the potential for collisions during backpatching around here.

Thanks for your kindly explanation.
Got it.

Regards,
Tang

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Remove double check when field_name is not NULL in be-secure-openssl.c
Next
From: Marcos Pegoraro
Date:
Subject: Trigger position