RE: [PATCH]Comment improvement in publication.sql - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: [PATCH]Comment improvement in publication.sql
Date
Msg-id OS0PR01MB611384E918DE96D23E3E9EAEFBF39@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: [PATCH]Comment improvement in publication.sql  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
Responses Re: [PATCH]Comment improvement in publication.sql  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Hi

I saw some inaccurate comments for AlterPublicationStmt structure when
reviewing patches related to publication[1].

The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
but the comments only say 'ADD/DROP'. How about add 'SET' to the comments?

typedef struct AlterPublicationStmt
{
    NodeTag        type;
    char       *pubname;        /* Name of the publication */

    /* parameters used for ALTER PUBLICATION ... WITH */
    List       *options;        /* List of DefElem nodes */

    /* parameters used for ALTER PUBLICATION ... ADD/DROP TABLE */
    List       *tables;            /* List of tables to add/drop */
    bool        for_all_tables; /* Special publication for all tables in db */
    DefElemAction tableAction;    /* What action to perform with the tables */
} AlterPublicationStmt;

It's also a comment improvement, so I add this change to this patch.
A new version patch is attached, pleases have a look.

[1]
https://www.postgresql.org/message-id/OS0PR01MB61132C2C4E2232258EB192FDFBF19%40OS0PR01MB6113.jpnprd01.prod.outlook.com

Regards
Tang

Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.
Next
From: Itamar Gafni
Date:
Subject: [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags