RE: [BUG]Update Toast data failure in logical replication - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: [BUG]Update Toast data failure in logical replication
Date
Msg-id OS0PR01MB61137DE0A63EC2AD65CFB35AFB3F9@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [BUG]Update Toast data failure in logical replication  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: [BUG]Update Toast data failure in logical replication
List pgsql-hackers
On Mon, May 31, 2021 5:12 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> 
> The problem is if the key attribute is not changed we don't log it as
> it should get logged along with the updated tuple, but if it is
> externally stored then the complete key will never be logged because
> there is no log from the toast table.  For fixing this if the key is
> externally stored then always log that.
> 
> Please test with the attached patch.

Thanks for your patch. I tested it and the bug was fixed.
I'm still trying to understand your fix, please allow me to ask more(maybe silly) questions if I found any.

+     * if the key hasn't changedand we're only logging the key, we're done.

I think "changedand" should be "changed and".

Regards
Tang

pgsql-hackers by date:

Previous
From: Esteban Zimanyi
Date:
Subject: Re: How to disable the autovacuum ?
Next
From: Dilip Kumar
Date:
Subject: Re: [BUG]Update Toast data failure in logical replication