RE: [PATCH] support tab-completion for single quote input with equal sign - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: [PATCH] support tab-completion for single quote input with equal sign
Date
Msg-id OS0PR01MB611358D336513EEECE7DE4B0FBCF9@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [PATCH] support tab-completion for single quote input with equal sign  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] support tab-completion for single quote input with equal sign
Re: [PATCH] support tab-completion for single quote input with equal sign
List pgsql-hackers
On Friday, September 3, 2021 2:14 AM, Jacob Champion <pchampion@vmware.com> wrote
>I applied your patch against HEAD (and did a clean build for good
>measure) but couldn't get the tab-completion you described -- on my
>machine, `PUBLICATION` still fails to complete. Tab completion is
>working in general, for example with the `SUBSCRIPTION` and
>`CONNECTION` keywords.
>
>Is there additional setup that I need to do?

Thanks for your check.

I applied the 0001-patch to the HEAD(c95ede41) by now and it worked as I expected.
Did you leave a space between "dbname=postgres'" and "[TAB]"?

In 0002-patch I added a tap test for the scenario of single quoted input with equal sign. 
The test result is 'All tests successful. ' on my machine. 
You can run the tap tests as follows:
1. Apply the attached patch
2. build the src with option '--enable-tap-tests' (./configure --enable-tap-tests)
3. Move to src subdirectory 'src/bin/psql' 
4. Run 'make check' 

I'd appreciate it if you can share your test results with me.

Regards,
Tang

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: PoC/WIP: Extended statistics on expressions
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: using an end-of-recovery record in all cases