RE: [PATCH] Add tab-complete for backslash commands - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: [PATCH] Add tab-complete for backslash commands
Date
Msg-id OS0PR01MB611343BAA677D11B97463422FBD49@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [PATCH] Add tab-complete for backslash commands  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Add tab-complete for backslash commands  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wednesday, September 8, 2021 5:05 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Sure, but he'd still get all the commands, just not all the possible
>spellings of each one.  And a person who's not sure what's available
>is unlikely to be helped by an entry for "\c", because it's entirely
>not clear which command that's an abbreviation for.
>
>In any case, my main point is that the primary usage of tab-completion
>is as a typing aid, not documentation.  I do not think we should make
>the behavior less useful for typing in order to be exhaustive on the
>documentation side.

You are right. I think I've got your point.
Here is the updated patch in which I added the multiple-character versions for backslash commands 
and remove their corresponding single-character version.
Of course, for backslash commands with only single-character version, no change added.

BTW, I've done the existing tap-tests for tab-completion with this patch, all tests passed.

Regards,
Tang

Attachment

pgsql-hackers by date:

Previous
From: Juan José Santamaría Flecha
Date:
Subject: Re: Atomic rename feature for Windows.
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Minimal logical decoding on standbys