RE: Parallel INSERT (INTO ... SELECT ...) - Mailing list pgsql-hackers

From houzj.fnst@fujitsu.com
Subject RE: Parallel INSERT (INTO ... SELECT ...)
Date
Msg-id OS0PR01MB5716D894437A7136661166AB94699@OS0PR01MB5716.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Parallel INSERT (INTO ... SELECT ...)  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Parallel INSERT (INTO ... SELECT ...)  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
> >      If a table parameter value is set and the
> >      equivalent <literal>toast.</literal> parameter is not, the TOAST table
> >      will use the table's parameter value.
> > -    Specifying these parameters for partitioned tables is not supported,
> > -    but you may specify them for individual leaf partitions.
> > +    These parameters, with the exception of
> > +    <literal>parallel_insert_enabled</literal>,
> > +    are not supported on partitioned tables, but may be specified for
> > +    individual leaf partitions.
> >     </para>
> >
> 
> Your patch looks good to me. While checking this, I notice a typo in the
> previous patch:
> -      planner parameter <varname>parallel_workers</varname>.
> +      planner parameter <varname>parallel_workers</varname> and
> +      <varname>parallel_insert_enabled</varname>.
> 
> Here, it should be /planner parameter/planner parameters.

Thanks amit and justin for pointing this out !
The changes looks good to me.

Best regards,
houzj


pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)
Next
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: libpq debug log