RE: Pgoutput not capturing the generated columns - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject RE: Pgoutput not capturing the generated columns
Date
Msg-id OS0PR01MB571691604527472B06B844AC944A2@OS0PR01MB5716.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: Pgoutput not capturing the generated columns  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
On Monday, October 28, 2024 2:54 PM Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote:
> 
> 
> 02. 031_column_list.pl
> 
> ```
> -# TEST: Generated and dropped columns are not considered for the column
> list.
> +# TEST: Dropped columns are not considered for the column list.
>  # So, the publication having a column list except for those columns and a  #
> publication without any column (aka all columns as part of the columns  #
> list) are considered to have the same column list.
> ```
> 
> Based on the comment, this case does not test the behavior of generated
> columns anymore. So, I felt column 'd' could be removed from the case.

I think keeping the generated column can test the cases you mentioned
in comment #03, so we can modify the comments here to make that clear.

> 
> 03. 031_column_list.pl
> 
> Can we test that generated columns won't be replaced if it does not included in
> the column list?

As stated above, it can be covered in existing tests.

Best Regards,
Hou zj

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Pgoutput not capturing the generated columns
Next
From: Daniel Gustafsson
Date:
Subject: Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated