[PATCH] Fix references in comments, and sync up heap_page_is_all_visible() with heap_page_prune_and_freeze() - Mailing list pgsql-hackers

From Gregory Burd
Subject [PATCH] Fix references in comments, and sync up heap_page_is_all_visible() with heap_page_prune_and_freeze()
Date
Msg-id O2XDwX3fiyQPKP740FHzy4_U4AXAQG7BM7z05YJ7lDn60o8ylIPTeM-3gaEdTrCKwIbkFofprj9IOtp6LN9WueiNUw5sjnx_H_E8AnSya2M=@burd.me
Whole thread Raw
List pgsql-hackers
While working on [1] I found an outdated comment in heap_page_is_all_visible() and two other small fixes.

0001: Updates that comment so future authors know that this "stripped down function" should retain the logic in
heap_page_prune_and_freeze(),not lazy_scan_prune() as was the case before 6dbb490. 
0002: Mimics the same loop logic as in heap_page_is_all_visible() so as to a) stay in sync and b) benefit from the
mentionedCPU prefetching optimization. 
0003: Moves the ItemSetPointer() just a bit further down in the function again to a) stay in sync and b) to sometimes
avoidthat tiny overhead. 

best,

-greg

PS: per-community standards I've switched to my personal email address rather than gregburd@amazon.com

[1] https://www.postgresql.org/message-id/flat/78574B24-BE0A-42C5-8075-3FA9FA63B8FC@amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: PostgreSQL 18 Beta 1 release announcement draft
Next
From: Robert Treat
Date:
Subject: Re: doc pg_constraint.convalidated column description need update