[Proposal] Level4 Warnings show many shadow vars - Mailing list pgsql-hackers

From Ranier Vilela
Subject [Proposal] Level4 Warnings show many shadow vars
Date
Msg-id MN2PR18MB2927F7B5F690065E1194B258E35D0@MN2PR18MB2927.namprd18.prod.outlook.com
Whole thread Raw
Responses Re: [Proposal] Level4 Warnings show many shadow vars  (Robert Haas <robertmhaas@gmail.com>)
Re: [Proposal] Level4 Warnings show many shadow vars  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
Hi,
I believe PostgreSQL can benefit from changing the alert level of compilation warnings.
The current Level3 level for windows does not show any alerts, but that does not mean that there are no problems.
Changing the level to Level4 and its equivalent for GCC in Unix environments will show many warnings for shadow
variables,including global variables. 
True, there will also be many silly alerts that can be safely disabled.
Shadow variables, although they may not currently represent bugs, may be hiding errors, or at the very least, it is a
wasteof variable declaration. 
With the current Level3 level, development is no longer checking and correcting shadow variables.

Any comments?

Best regards,
Ranier Vilela


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: fe-utils - share query cancellation code
Next
From: Michael Paquier
Date:
Subject: Re: pgbench -i progress output on terminal