Outdated comments in AssignTransactionId? - Mailing list pgsql-hackers

From Japin Li
Subject Outdated comments in AssignTransactionId?
Date
Msg-id MEYP282MB1669F1154D12464D399C5FDBB6319@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
List pgsql-hackers
The AssignTransactionId has the following comments:

        /*
         * ensure this test matches similar one in
         * RecoverPreparedTransactions()
         */
        if (nUnreportedXids >= PGPROC_MAX_CACHED_SUBXIDS ||
            log_unknown_top)
        {
            ...
        }

However, RecoverPreparedTransactions removes this reference in 49e9281549.
Attached remove this reference in AssignTransactionId.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index fd5103a78e..fe0cf5527b 100644
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -741,10 +741,6 @@ AssignTransactionId(TransactionState s)
         unreportedXids[nUnreportedXids] = XidFromFullTransactionId(s->fullTransactionId);
         nUnreportedXids++;
 
-        /*
-         * ensure this test matches similar one in
-         * RecoverPreparedTransactions()
-         */
         if (nUnreportedXids >= PGPROC_MAX_CACHED_SUBXIDS ||
             log_unknown_top)
         {

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Improve tab completion for ALTER STATISTICS
Next
From: Peter Smith
Date:
Subject: Re: GUC values - recommended way to declare the C variables?