Re: Another incorrect comment for pg_stat_statements - Mailing list pgsql-hackers

From Japin Li
Subject Re: Another incorrect comment for pg_stat_statements
Date
Msg-id MEYP282MB16696B7FB5505879710AA2E4B624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Another incorrect comment for pg_stat_statements  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Another incorrect comment for pg_stat_statements
List pgsql-hackers
On Wed, 28 Jun 2023 at 16:27, Richard Guo <guofenglinux@gmail.com> wrote:
> On Wed, Jun 28, 2023 at 3:36 PM Michael Paquier <michael@paquier.xyz> wrote:
>
>> On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote:
>> > +1.  To nitpick, how about we remove the blank line just before removing
>> > the key for top level entry?
>> >
>> > -  /* Also remove entries for top level statements */
>> > +  /* Also remove entries if exist for top level statements */
>> >    key.toplevel = true;
>> > -
>> > -  /* Remove the key if exists */
>> >    entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
>>
>> Why not if it improves the overall situation.  Could you send a patch
>> with everything you have in mind?
>
>
> Here is the patch.  I don't have too much in mind, so the patch just
> removes the blank line and revises the comment a bit.
>

+1. LGTM.

--
Regrads,
Japin Li.



pgsql-hackers by date:

Previous
From: Terry Brennan
Date:
Subject: Re: Request for new function in view update
Next
From: torikoshia
Date:
Subject: Re: pg_rewind WAL segments deletion pitfall