Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption - Mailing list pgsql-bugs

From Japin Li
Subject Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption
Date
Msg-id ME3P282MB316673BAB0531593C736DAF1B6F42@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption  (Önder Kalacı <onderkalaci@gmail.com>)
Responses Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption
List pgsql-bugs
On Thu, 23 May 2024 at 14:54, Önder Kalacı <onderkalaci@gmail.com> wrote:
> Hi Japin,
>
> Thanks, the patch looks good to me.
>
> However, as a non-native English speaker, it might not be accurate.
>> Feel free to modify it.
>>
>>
> I'm also not good at wording, but I have a minor suggestions like the
> following :
>
> /*
>  * Also, the FETCH FIRST/NEXT ... ROW/ROWS WITH TIES clause cannot be
> pushed down
>  * because:
>  * a) The remote system may have a different understanding of equality,
> which can
>  *    result in varying results, such as non-deterministic collations.
>  * b) We do not have knowledge of the remote server's version
>  *    as this clause is only supported for PG13 and above.
>  */
>

Thanks for your review!  Fixed in v5 patch.

--
Regards,
Japin Li


Attachment

pgsql-bugs by date:

Previous
From: Robert Haas
Date:
Subject: Re: BUG #18362: unaccent rules and Old Greek text
Next
From: Laurenz Albe
Date:
Subject: Re: Bug report - pg_upgrade tool seems to have a race condition when trying to delete a pg_wal file