Minor bug and suggested fix - 1.2 and 1.3.5 - Mailing list pgadmin-hackers

From Mark A. Taff
Subject Minor bug and suggested fix - 1.2 and 1.3.5
Date
Msg-id LOBBLBDHPFLLCMMKPMFKEECFDDAA.mark@libertycreek.net
Whole thread Raw
List pgadmin-hackers

All,

            I’ve found a minor bug in 1.2 and 1.3.5.  When an uncorrected error occurs and LogError is called after StartMsg has been called, EndMsg is not always called, and so the cursor does not always return to a normal cursor.  Rather than trying to check and correct for this throughout the code, I’ve just done it once in the LogError sub.  I’ve pasted patched code based on 1.3.5 for your consideration below.

 

Regards,

 

Mark Taff

 

*** Begin patch for pgAdmin2.basMisc.LogError v1.3.5 ***

 

Public Sub LogError(lError As Long, szError As String, szRoutine As String)

'No logging here, if anythings going wrong then we want the real error

 

  frmMain.svr.LogEvent "Error in " & szRoutine & ": " & lError & " - " & szError, etErrors

  MsgBox "An error has occured in " & szRoutine & ":" & vbCrLf & vbCrLf & "Number: " & lError & vbCrLf & "Description: " & szError, vbExclamation, App.Title & " Error"

 

  'If we get here, EndMsg may not fire, so give the user a normal cursor...

  Screen.MousePointer = vbDefault

 

End Sub

 

*** End patch ***

pgadmin-hackers by date:

Previous
From: "sreedhar" (by way of Jean-Michel POURE
Date:
Subject: [ADMIN] Problem while connecting pgAdmin II v1.2
Next
From: Dave Page
Date:
Subject: Re: Minor bug and suggested fix - 1.2 and 1.3.5