Re: Teach pg_receivewal to use lz4 compression - Mailing list pgsql-hackers

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Saturday, September 11th, 2021 at 07:02, Jian Guo <gjian@vmware.com> wrote:

Hi,

thank you for looking at the patch.

> -             LZ4F_decompressionContext_t ctx = NULL;
> -             snprintf(fullpath, sizeof(fullpath), "%s/%s", basedir, dirent->d_name);
> -             fd = open(fullpath, O_RDONLY | PG_BINARY, 0);
>
> Should close the fd before exit or abort.

You are correct. Please find version 4 attached.

Cheers,
//Georgios