Add FOREIGN to ALTER TABLE in pg_dump - Mailing list pgsql-hackers

From Luis Carril
Subject Add FOREIGN to ALTER TABLE in pg_dump
Date
Msg-id LEJPR01MB0185A19B2E7C98E5E2A031F5E7F20@LEJPR01MB0185.DEUPRD01.PROD.OUTLOOK.DE
Whole thread Raw
Responses Re: Add FOREIGN to ALTER TABLE in pg_dump  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hello,
    pg_dump creates plain ALTER TABLE statements even if the table is a foreign table, which for someone reading the dump is confusing.
    This also made a difference when applying the dump if there is any plugin installed that hooks on ProcessUtility, because the plugin could react differently to ALTER TABLE than to ALTER FOREIGN TABLE.  Opinions?

    An unrelated question: if I apply pgindent to a file (in this case pg_dump.c) and get a bunch of changes on the indentation that are not related to my patch, which is the accepted policy? A different patch first with only the indentation?  Maybe, am I using pgindent wrong?

Cheers
Luis M Carril
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Check-out mutable functions in check constraints
Next
From: Eugen Konkov
Date:
Subject: Re: Request for improvement: Allow to push (t.o).id via GROUP BY ocd.o