Re: pg_upgrade version checking questions - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_upgrade version checking questions
Date
Msg-id L-956-YkM0DEV1jOI3O32iVnD4I4ZMoqfOPwots1c4Q1dI9jNOn4QSlANcQk2FwJE4Yv_sXIuT5Ty759nITA4BxUq_znsxGrVaC5BTP5buU=@yesql.se
Whole thread Raw
In response to Re: pg_upgrade version checking questions  (Christoph Berg <myon@debian.org>)
Responses Re: pg_upgrade version checking questions
List pgsql-hackers
On Wednesday, March 27, 2019 1:43 PM, Christoph Berg <myon@debian.org> wrote:

> Re: Daniel Gustafsson 2019-03-26
pC-NMmh4vQLQP76YTwY4AuoD4OdNw9egikekyQpXFpgqmTlGjIZXOTd2W5RDZPpRski5N3ADRrLYgLk6QUuvmuT5fWC9acPAYyDU1AVxJcU=@yesql.se
>
> > 0003 - Make -B default to CWD and remove the exec_path check
> > Defaulting to CWD for the new bindir has the side effect that the default
> > sockdir is in the bin/ directory which may be less optimal.
>
> Hmm, I would have thought that the default for the new bindir is the
> directory where pg_upgrade is located, not the CWD, which is likely to
> be ~postgres or the like?

Yes, thinking on it that's obviously better.  The attached v2 repurposes the
find_my_exec() check to make the current directory of pg_upgrade the default
for new_cluster.bindir (the other two patches are left as they were).

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Inadequate executor locking of indexes
Next
From: David Fetter
Date:
Subject: Re: Retronym: s/magnetic disk/main data/