[BUGS] postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ? - Mailing list pgsql-bugs

From David Binderman
Subject [BUGS] postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?
Date
Msg-id HE1PR0802MB233122B61F00A15E035C83BE9C710@HE1PR0802MB2331.eurprd08.prod.outlook.com
Whole thread Raw
Responses Re: [BUGS] postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Hello there,

postgresql-10.0/src/bin/psql/mainloop.c:461] -> [postgresql-10.0/src/bin/psql/mainloop.c:465]: (warning) Opposite inner
'if'condition leads to a dead code block. 

Source code is
   if (query_buf->len > 0 && !pset.cur_cmd_interactive &&       successResult == EXIT_SUCCESS)   {       /* save query
inhistory */       if (pset.cur_cmd_interactive)           pg_send_history(history_buf); 

It looks like function pg_send_history can never be executed.

Regards

David Binderman

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Noah Misch
Date:
Subject: Re: [BUGS] BUG #14794: Installation failure if user specify French password
Next
From: buschmann@nidsa.net
Date:
Subject: [BUGS] BUG #14844: Failure/Duplicate key value with ALTER DATABASE setsearch_path