RE: pgstat_report_activity() and parallel CREATE INDEX (was: Parallelindex creation & pg_stat_activity) - Mailing list pgsql-hackers

From Phil Florent
Subject RE: pgstat_report_activity() and parallel CREATE INDEX (was: Parallelindex creation & pg_stat_activity)
Date
Msg-id HE1PR03MB170661648BD28D1FEC1BE200BAA20@HE1PR03MB1706.eurprd03.prod.outlook.com
Whole thread Raw
In response to Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallelindex creation & pg_stat_activity)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

Thanks, ran the original test and it works great after the patch.

Phil




De : Robert Haas <robertmhaas@gmail.com>
Envoyé : jeudi 22 mars 2018 18:17
À : Peter Geoghegan
Cc : Andres Freund; Phil Florent; PostgreSQL Hackers
Objet : Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity)
 
On Wed, Mar 7, 2018 at 8:53 PM, Peter Geoghegan <pg@bowt.ie> wrote:
> On Thu, Mar 1, 2018 at 2:47 PM, Peter Geoghegan <pg@bowt.ie> wrote:
>> No. Just an oversight. Looks like _bt_parallel_build_main() should
>> call pgstat_report_activity(), just like ParallelQueryMain().
>>
>> I'll come up with a patch soon.
>
> Attached patch has parallel CREATE INDEX propagate debug_query_string
> to workers. Workers go on to use this string as their own
> debug_query_string, as well as registering it using
> pgstat_report_activity(). Parallel CREATE INDEX pg_stat_activity
> entries will have a query text, too, which addresses Phil's complaint.

Committed.  Thanks for the patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Add documentation for the JIT feature.
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] A design for amcheck heapam verification