Re: BETWEEN Node & DROP COLUMN - Mailing list pgsql-hackers

From Christopher Kings-Lynne
Subject Re: BETWEEN Node & DROP COLUMN
Date
Msg-id GNELIHDDFBOCMGBFGEFOOEPJCCAA.chriskl@familyhealth.com.au
Whole thread Raw
In response to Re: BETWEEN Node & DROP COLUMN  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BETWEEN Node & DROP COLUMN  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
List pgsql-hackers
> It sounds to me like you've failed to make sure that the field is
> initialized properly when a pg_attribute row is dynamically created.
> Let's see... did you fix the static FormData_pg_attribute rows near
> the top of heap.c?  Does TupleDescInitEntry() know about initializing
> the field?  (I wonder why it doesn't memset() the whole row to zero
> anyway...)

OK I'll look at them.

> pg_attribute is very possibly the most ticklish system catalog
> to add a column to.  I'd suggest looking through every single use of
> some other pg_attribute column, perhaps attstattarget or attnotnull,
> to make sure you're initializing attisdropped everywhere it should be.

OK, I'm on the case.

Chris





pgsql-hackers by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: BETWEEN Node & DROP COLUMN
Next
From: Rod Taylor
Date:
Subject: Re: BETWEEN Node & DROP COLUMN