Re: Unescaped new lines in postgres - Mailing list pgsql-hackers

From Christopher Kings-Lynne
Subject Re: Unescaped new lines in postgres
Date
Msg-id GNELIHDDFBOCMGBFGEFOMEIKCAAA.chriskl@familyhealth.com.au
Whole thread Raw
In response to Re: Unescaped new lines in postgres  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Unescaped new lines in postgres
Re: Unescaped new lines in postgres
List pgsql-hackers
>From heap.c:
      /*        * sanity checks        */       if (relname && !allow_system_table_mods &&
IsSystemRelationName(relname)&& IsNormalProcessingMode())               elog(ERROR, "invalid relation name \"%s\"; "
                   "the 'pg_' name prefix is reserved for system
 
catalogs",                        relname);

I guess this is a slightly different example than what the issue is below.
Maybe I'm wrong and the above code is still legal.  Even so, seems a bit
dodgy to me...

Chris

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> Sent: Friday, 23 November 2001 12:26 PM
> To: Christopher Kings-Lynne
> Cc: Hackers
> Subject: Re: [HACKERS] Unescaped new lines in postgres
>
>
>
> Can you show an example?
>
> ------------------------------------------------------------------
> ---------
>
> > >From the gcc 3.0.2 release ntoes:
> >
> > "The poorly documented extension that allowed string constants
> in C, C++ and
> > Objective C to contain unescaped newlines has been deprecated and may be
> > removed in a future version. Programs using this extension may
> be fixed in
> > several ways: the bare newline may be replaced by \n, or
> preceded by \n\, or
> > string concatenation may be used with the bare newline preceded
> by \n" and "
> > placed at the start of the next line. "
> >
> > I seem to recall that I came across a fair bit of this kind of
> thing in the
> > psql source code at least.  I wonder if it should be fixed to be
> > compliant...
> >
> > Chris
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> >     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
> >
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
>



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: v7.2b3 packaged, but not announced beyond here yet ...
Next
From: Tatsuo Ishii
Date:
Subject: Re: OCTET_LENGTH is wrong