Re: RecoveryInProgress() has critical side effects - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: RecoveryInProgress() has critical side effects
Date
Msg-id FE730879-BCD5-44E8-9FD6-7DAA5E06C948@amazon.com
Whole thread Raw
In response to Re: RecoveryInProgress() has critical side effects  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: RecoveryInProgress() has critical side effects
List pgsql-hackers
On 11/15/21, 1:30 PM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> Here's a new version that does it that way. Any other opinions?

LGTM

> The best thing I could come up with for a test case for this was to
> try repeatedly making a new connection and running "SELECT
> txid_current()", which will cause just one WAL record to be generated.
> Unfortunately that path has overhead from a lot of other causes so I'm
> not sure the results are very meaningful, but here they are:
>
> v1: 0.378 ms
> v2: 0.391 ms
> common base commit (10eae82b2): 0.376 ms

I'm personally not too worried about a ~4% regression in this
particular benchmark...

Nathan


pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [RFC] building postgres with meson
Next
From: "Bossart, Nathan"
Date:
Subject: Re: [PATCH v2] use has_privs_for_role for predefined roles