Re: Improved error message for CREATE EXTENSION patch... - Mailing list pgsql-hackers

From Sean Chittenden
Subject Re: Improved error message for CREATE EXTENSION patch...
Date
Msg-id FAA5F039-AE85-429B-90C1-F13CBEC1B39A@chittenden.org
Whole thread Raw
In response to Re: Improved error message for CREATE EXTENSION patch...  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Improved error message for CREATE EXTENSION patch...
List pgsql-hackers
>>> "ERROR:  XX000: no schemas in search_path are available for CREATE EXTENSION"
>
> Hm, I'm not sure that's much better than the existing wording.  The
> bigger point here though is that if we consider this to be a user-facing
> error case, it ought to be ereport not elog.
>
> I checked what you get for the normal non-extension case:
>
> regression=# set search_path = bogus;
> SET
> regression=# create table t1 (f1 int);
> ERROR:  no schema has been selected to create in
> regression=# \set VERBOSITY verbose
> regression=# create table t1 (f1 int);
> ERROR:  3F000: no schema has been selected to create in
> LOCATION:  RangeVarGetCreationNamespace, namespace.c:485
>
> Seems like we ought to use the same message (and SQLSTATE) as in
> namespace.c, since nobody's complained about that one.


Sounds good to me and is clear enough that it would unblock me w/o having to resort to the source tree. -sc


--
Sean Chittenden
sean@chittenden.org




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Configurable location for extension .control files
Next
From: Tom Lane
Date:
Subject: Re: Configurable location for extension .control files