Re: Reducing connection overhead in pg_upgrade compat check phase - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Reducing connection overhead in pg_upgrade compat check phase
Date
Msg-id FA58EDD7-97F8-418E-BE4A-511616DB8ADB@yesql.se
Whole thread Raw
In response to Re: Reducing connection overhead in pg_upgrade compat check phase  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Reducing connection overhead in pg_upgrade compat check phase
List pgsql-hackers
> On 13 Sep 2023, at 16:12, Peter Eisentraut <peter@eisentraut.org> wrote:

> The alignment of this output looks a bit funny:
>
> ...
> Checking for prepared transactions                            ok
> Checking for contrib/isn with bigint-passing mismatch         ok
> Checking for data type usage                                  checking all databases
> ok
> Checking for presence of required libraries                   ok
> Checking database user is the install user                    ok
> ...

I was using the progress reporting to indicate that it hadn't stalled for slow
systems, but it's not probably not all that important really.  Removed such
that "ok" aligns.

> Also, you should put gettext_noop() calls into the .status = "Checking ..."
> assignments and arrange to call gettext() where they are used, to maintain
> the translatability.

Ah, yes of course. Fixed.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Damir Belyalov
Date:
Subject: Re: Redundant Unique plan node for table with a unique index
Next
From: Amul Sul
Date:
Subject: Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression