> On 1 Nov 2021, at 17:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 1 Nov 2021, at 14:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> +1, but there are also C4819 warnings in fe_utils/print.c. Can we get
>>> rid of that too? That one's a bit more integral to the code, since
>>> (I think) it's complaining about the comments in the unicode_style table.
>>> But maybe we could replace those with Unicode codes + symbol names?
>
>> Aha, I missed that one when skimming the (quite chatty) log. The attached
>> addresses that file as well, replacing the comments with codepoints and names.
>> It does make the section of the code more verbose, but also more readable IMO.
>
> Generally +1, but I think you'll need to add some dashes to keep pgindent
> from re-flowing those comment blocks (which would be a big hit to the
> readability).
Agreed. Done with reflow-guards for pgindent.
--
Daniel Gustafsson https://vmware.com/
