Re: Allow non-superuser to cancel superuser tasks. - Mailing list pgsql-hackers

From Andrey M. Borodin
Subject Re: Allow non-superuser to cancel superuser tasks.
Date
Msg-id F9A78C39-464C-42B6-AC9E-481BEF66D7B4@yandex-team.ru
Whole thread Raw
In response to Re: Allow non-superuser to cancel superuser tasks.  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Allow non-superuser to cancel superuser tasks.
Re: Allow non-superuser to cancel superuser tasks.
List pgsql-hackers

> On 13 Jun 2024, at 02:04, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> I adjusted 0001 based on my upthread feedback.

This patch looks good to me. Spellchecker is complaining about “signaling” instead of “signalling”, but ISTM it’s OK.

I’ve tried to dig into the test.
The problem is CV is allocated in

inj_state = GetNamedDSMSegment("injection_points”,

which seems to be destroyed in

shmem_exit() calling dsm_backend_shutdown()

This happens before we broadcast that sleep is over.
I think this might happen with any wait on injection point if it is pg_terminate_backend()ed.

Is there way to wake up from CV sleep before processing actual termination?

Thanks!


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical Replication of sequences
Next
From: Dominique Devienne
Date:
Subject: Re: Improve the granularity of PQsocketPoll's timeout parameter?