Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator - Mailing list pgsql-hackers

From Roma Sokolov
Subject Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator
Date
Msg-id F91420DD-0209-44EA-AB37-B22F641EC943@gmail.com
Whole thread Raw
In response to Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator  (Euler Taveira <euler@timbira.com.br>)
Responses Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator  (Euler Taveira <euler@timbira.com.br>)
Re: [PATCH] fix DROP OPERATOR to reset links to itself oncommutator and negator  (Yury Zhuravlev <u.zhuravlev@postgrespro.ru>)
List pgsql-hackers
Tree view 
Thanks for comments, Euler!

> ... is hard to understand. Instead, you could separate the conditional
> expression into a variable.

Fixed the patch to be more descriptive and to avoid repeating same
computation over and over again. See v2 of the patch attached.

> I don't think those are mandatory.


Why do you think that? Should I remove them or maybe send as separate
patch?

Cheers,
Roma
Attachment

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: The plan for FDW-based sharding
Next
From: Michael Paquier
Date:
Subject: Re: [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc.