Refactor SASL exchange in preparation for OAuth Bearer - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Refactor SASL exchange in preparation for OAuth Bearer
Date
Msg-id F51F8777-FAF5-49F2-BC5E-8F9EB423ECE0@yesql.se
Whole thread Raw
Responses Re: Refactor SASL exchange in preparation for OAuth Bearer
List pgsql-hackers
The attached two patches are smaller refactorings to the SASL exchange and init
codepaths which are required for the OAuthbearer work [0].  Regardless of the
future of that patchset, these refactorings are nice cleanups and can be
considered in isolation.  Another goal is of course to reduce scope of the
OAuth patchset to make it easier to review.

The first patch change state return from the exchange call to use a tri-state
return value instead of the current output parameters.  This makes it possible
to introduce async flows, but it also makes the code a lot more readable due to
using descriptve names IMHO.

The second patch sets password_needed during SASL init on the SCRAM exchanges.
This was implicit in the code but since not all future exchanges may require
password, do it explicitly per mechanism instead.

--
Daniel Gustafsson

[0] d1b467a78e0e36ed85a09adf979d04cf124a9d4b.camel@vmware.com


Attachment

pgsql-hackers by date:

Previous
From: Alexander Pyhalov
Date:
Subject: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack
Next
From: Daniel Gustafsson
Date:
Subject: Re: Potential issue in ecpg-informix decimal converting functions