Re: New developer papercut - Makefile references INSTALL - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: New developer papercut - Makefile references INSTALL
Date
Msg-id F2F48D23-6109-474B-9D9A-95294804B488@yesql.se
Whole thread Raw
In response to New developer papercut - Makefile references INSTALL  ("Tim McNamara" <tim@mcnamara.nz>)
Responses Re: New developer papercut - Makefile references INSTALL
List pgsql-hackers
> On 17 Jan 2022, at 02:11, Tim McNamara <tim@mcnamara.nz> wrote:
>
> Hello,
>
> I encountered a minor road bump when checking out the pg source today. The Makefile's all target includes the
followinghelp message if GNUmakefile isn't available:  
>
>  echo "You need to run the 'configure' program first. See the file"; \
>  echo "'INSTALL' for installation instructions." ; \
>
> After consulting README.git, it looks as though INSTALL isn't created unless the source is bundled into a release or
snapshottarball. I'm happy to submit a patch to update the wording, but wanted to check on the preferred approach. 
>
> Perhaps this would be sufficient?
>
>  echo "You need to run the 'configure' program first. See the file"; \
>  echo "'INSTALL' for installation instructions, or visit" ; \
>  echo "<https://www.postgresql.org/docs/devel/installation.html>" ; \

That's a good point, and one few developers are likely to spot so thanks for
raising the issue.  To avoid replicating the wording we can do something like
the attached as well.

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication
Next
From: Heikki Linnakangas
Date:
Subject: Re: SLRUs in the main buffer pool, redux