Re: tableam: abstracting relation sizing code - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: tableam: abstracting relation sizing code
Date
Msg-id EE6EBBB3-62E9-49D1-80AE-65C943983961@yesql.se
Whole thread Raw
In response to Re: tableam: abstracting relation sizing code  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
> On 10 Jun 2019, at 21:35, Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Fri, Jun 7, 2019 at 6:42 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>> Good catch, and now I notice that the callback is not called
>>> estimate_rel_size but relation_estimate_size.  Updated patch attached;
>>> thanks for the review.
>>
>> The commit message still refers to it as estimate_rel_size though. The comment on
>> table_block_relation_estimate_size does too but that one might be intentional.
>
> Oops.  New version attached, hopefully fixing those and the compiler
> warning Alvaro noted.

+1 on this version of the patch, no warning, passes tests and looks good.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Adaptive query optimization
Next
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Speedup truncates of relation forks