Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library
Date
Msg-id E8AE4B13-E938-4930-A099-FD9D650E1AA5@yesql.se
Whole thread Raw
In response to Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library  (Hugh McMaster <hugh.mcmaster@outlook.com>)
Re: [PATCH] Use PKG_CHECK_MODULES to detect the libxml2 library  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 10 Mar 2020, at 18:38, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> On 2020-03-10 12:41, Daniel Gustafsson wrote:
>>> On 10 Mar 2020, at 11:53, Hugh McMaster <hugh.mcmaster@outlook.com> wrote:
>>> Debian (and Ubuntu) are beginning to remove foo-config legacy scripts.
>>> Already, xml2-config has been flagged for removal, with packages being
>>> asked to switch to pkg-config.
>>>
>>> This patch uses pkg-config's PKG_CHECK_MODULES macro to detect libxml2
>>> or, if pkg-config is not available, falls back to xml2-confg.
>> This was previously discussed in 20200120204715.GA73984@msg.df7cb.de which
>> ended without a real conclusion on what could/should be done (except that
>> nothing *had* to be done).
>> What is the situation on non-Debian/Ubuntu systems (BSD's, macOS etc etc)?  Is
>> it worth adding pkg-config support if we still need a fallback to xml2-config?
>
> Btw., here is an older thread for the same issue
<https://www.postgresql.org/message-id/flat/1358164265.29612.7.camel%40vanquo.pezone.net>. Might be worth reflecting on
theissues discussed there. 

Thanks, didn't realize that the subject had been up for discussion earlier as
well.

For me, the duplication aspect is the most troubling, since we'd still need the
xml2-config fallback and thus won't be able to simplify the code.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: Berserk Autovacuum (let's save next Mandrill)
Next
From: Andres Freund
Date:
Subject: Re: shared-memory based stats collector