Re: What has happened to pgxs? - Mailing list pgsql-hackers

From Dave Page
Subject Re: What has happened to pgxs?
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E4CC2E76@ratbert.vale-housing.co.uk
Whole thread Raw
In response to What has happened to pgxs?  (Thomas Hallgren <thhal@mailblocks.com>)
List pgsql-hackers

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 23 September 2005 15:48
> To: Dave Page
> Cc: Michael Paesold; Thomas Hallgren; pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] What has happened to pgxs?
>
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> >> It does?  Dave just told us that the standard installer
> >> package is built to install into /usr/local/pgsql.
>
> > No, I said it's built into the installer from
> /usr/local/pgsql (the path
> > in the msys dev environment). It actually installs into C:\Program
> > Files\PostgreSQL\8.X which is where users run it from.
>
> Hmm ... so the real issue is that pgxs sees the installation directory
> as named differently from what it was named during backend build.  OK,
> that makes this behavior a problem, considering that we nominally
> support being able to relocate installations.  Not sure what to do
> about it though.  Perhaps pgxs should be interrogating pg_config for
> the various path names instead of assuming it can recompute them?

That would be a definite improvement, however it may well run into the
whitespace issues that Thomas mentioned - apparently the makefiles need
short Windows filenames if there are any spaces in them - eg, instead
of:

C:/Program Files/PostgreSQL

We need

C:/Progra~1/PostgreSQL

The GetShortPathName() API should do this, though some reversing of the
/'s might be required first (and if so, they'll need to be flipped back
again afterwards). I'm tied up with other stuff right now though so I
can't really look atm.

Regards, Dave.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: What has happened to pgxs?
Next
From: Simon Riggs
Date:
Subject: Re: Releasing memory during External sorting?