Re: Server instrumentation patch - Mailing list pgsql-hackers

From Dave Page
Subject Re: Server instrumentation patch
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E490E717@ratbert.vale-housing.co.uk
Whole thread Raw
In response to Server instrumentation patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Server instrumentation patch
List pgsql-hackers

> -----Original Message-----
> From: Michael Paesold [mailto:mpaesold@gmx.at]
> Sent: 24 June 2005 17:53
> To: Dave Page; Andreas Pflug
> Cc: PostgreSQL-development
> Subject: Re: [HACKERS] Server instrumentation patch
>
> > My main concern is that the names are inconsistent for no obvious
> > reason.
>
> That could be fixed by having:
> pg_database_size(name)
> pg_database_size(oid)
>
> The original idea was probably to name "internal" functions
> with pg_ and
> more user friendly ones without pg_. That does not mean it's
> a good idea.

Yes, agreed - it could be fixed that way easily. If the inclusion of
/all/ functions is for backwards compatibility though, then that change
is somewhat more of a problem.

>
> Well, I don't feel this is really bloat. I have been using
> them since the
> creation of the contrib module and have found them quite useful.

Fair enough.

Regards, Dave.


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Server instrumentation patch
Next
From: Bruce Momjian
Date:
Subject: Re: Server instrumentation patch