Re: [PATCH] pg_autovacuum commandline password hiding. - Mailing list pgsql-patches

From Dave Page
Subject Re: [PATCH] pg_autovacuum commandline password hiding.
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E490E08C@ratbert.vale-housing.co.uk
Whole thread Raw
In response to [PATCH] pg_autovacuum commandline password hiding.  (Ian FREISLICH <if@hetzner.co.za>)
Responses Re: [PATCH] pg_autovacuum commandline password hiding.
List pgsql-patches

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 24 May 2005 16:02
> To: Dave Page
> Cc: Ian FREISLICH; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] [PATCH] pg_autovacuum commandline
> password hiding.
>
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> >> Which is exactly why we don't (and won't) provide such a switch.
>
> > Err, yes we do:
>
> Um, sorry, I totally misread Ian's patch as a proposal that we add a
> password switch (I hate unidiffs ;-)).

:-)

> I would argue actually that this switch is a horrible idea and we
> must take it out entirely.  The method Ian proposes for hiding the
> password after reading it is certainly not portable in the slightest,
> and even if we could make it work on all platforms (which we can't)
> I don't think it would be good enough, because there would still be
> a window where the superuser password was exposed to view before
> we could wipe it out.

Agreed. The attached patch should do the trick.

Regards, Dave

Attachment

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] pg_autovacuum commandline password hiding.
Next
From: Andrew Dunstan
Date:
Subject: Re: plperl strict mode