Re: Odbcapi30.c - 64 bit compiler warning cleanup - Mailing list pgsql-odbc

From Dave Page
Subject Re: Odbcapi30.c - 64 bit compiler warning cleanup
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E40103DBEE@ratbert.vale-housing.co.uk
Whole thread Raw
In response to Odbcapi30.c - 64 bit compiler warning cleanup  ("Dave Page" <dpage@vale-housing.co.uk>)
Responses Re: Odbcapi30.c - 64 bit compiler warning cleanup  (Ludek Finstrle <luf@pzkagis.cz>)
List pgsql-odbc

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 27 January 2006 14:45
> To: Dave Page
> Cc: Ludek Finstrle; pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] Odbcapi30.c - 64 bit compiler warning cleanup
>
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> >> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> >> The problem with this is that it creates an ABI breakage.
>
> > Is that actually a problem given that apps should link to the driver
> > manager (which can dynamically load any version of any driver), not
> > directly to the driver itself?
>
> Hm, good point.  So the question then becomes whether the
> driver manager
> is expecting this parameter to be int-sized or pointer-sized.

It /should/ be expecting SQLPOINTER (well, SQLSetConnectAttr expects
SQLPOINTER, and SQLSetConnectOption maps directly to it according to the
spec -
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/odbc/ht
m/odbcsqlsetconnectattr.asp)

> I took a quick look at the unixODBC sources (2.0.4 which is
> what I have
> handy, I know it's a bit old) and got completely confused: I see the
> parameter declared as SQLUINTEGER in some places and UDWORD in others.
> Anyone know that code base well enough to be certain which place is
> definitive?

Not I. Our code seems to be a mess of types as well :-(

Regards, Dave.

pgsql-odbc by date:

Previous
From: Tom Lane
Date:
Subject: Re: Odbcapi30.c - 64 bit compiler warning cleanup
Next
From: Ludek Finstrle
Date:
Subject: Re: network saturation