Re: PG_COLOR not mentioned in docs of vacuumlo, oid2name and pgbench - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: PG_COLOR not mentioned in docs of vacuumlo, oid2name and pgbench
Date
Msg-id E640D609-E62B-40D8-8148-62219F3EA993@yesql.se
Whole thread Raw
In response to PG_COLOR not mentioned in docs of vacuumlo, oid2name and pgbench  (Michael Paquier <michael@paquier.xyz>)
Responses Re: PG_COLOR not mentioned in docs of vacuumlo, oid2name and pgbench
List pgsql-hackers
> On 4 Mar 2020, at 08:54, Michael Paquier <michael@paquier.xyz> wrote:

> All the tools mentioned in $subject have been switched recently to use
> the central logging infrastructure, which means that they have gained
> coloring output.  However we (mostly I) forgot to update the docs.

+1 on updating the docs with PG_COLOR for these.

> Attached is a patch to fix this issue.  Please let me know if there
> are comments and/or objections.

+   color in diagnostics messages.  Possible values are
+   <literal>always</literal>, <literal>auto</literal>,
+   <literal>never</literal>.

Not being a native english speaker, I might have it backwards, but I find lists
of values in a sentence like this to be easier to read when the final value is
separated by a conjunction like:

    <item 1>, <item 2>, .. , <item n-1> and <item n>

cheers ./daniel


pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Daniel Gustafsson
Date:
Subject: Re: PG14 target version?