Re: BUG #17212: pg_amcheck fails on checking temporary relations - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: BUG #17212: pg_amcheck fails on checking temporary relations
Date
Msg-id E283B45F-5745-49C9-BBC7-99876E2FABD1@enterprisedb.com
Whole thread Raw
Responses Re: BUG #17212: pg_amcheck fails on checking temporary relations
List pgsql-hackers

> On Oct 3, 2021, at 10:04 AM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>
>> On Oct 2, 2021, at 10:32 AM, Peter Geoghegan <pg@bowt.ie> wrote:
>>
>> On Sat, Oct 2, 2021 at 4:49 AM PG Bug reporting form
>> <noreply@postgresql.org> wrote:
>>> Although you can add --exclude-relation=*.pg_temp*.*, this behaviour differs
>>> from the behaviour of pg_dump and friends, which skip such relations
>>> silently.
>>
>> I agree -- this behavior is a bug.
>>
>> Can you propose a fix, Mark?
>
> The attached patch includes a test case for this, which shows the problems against the current pg_amcheck.c, and a
newversion of pg_amcheck.c which fixes the bug.  Could you review it? 
>
> Thanks for bringing this to my attention.

Reposting to pgsql-hackers in preparation for making a commitfest entry.



—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Triage on old commitfest entries
Next
From: Masahiko Sawada
Date:
Subject: Re: Skipping logical replication transactions on subscriber side