pgsql: postgres_fdw: Add Assert to estimate_path_cost_size(). - Mailing list pgsql-committers

From Etsuro Fujita
Subject pgsql: postgres_fdw: Add Assert to estimate_path_cost_size().
Date
Msg-id E1uYKat-004wDJ-14@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
postgres_fdw: Add Assert to estimate_path_cost_size().

When estimating the cost/size of a pre-sorted path for a given upper
relation using local stats, this function dereferences the passed-in
PgFdwPathExtraData pointer without checking that it is not NULL.  But
that is not a bug as the pointer is guaranteed to be non-NULL in that
case; to avoid confusion, add an Assert to ensure that it is not NULL
before dereferencing it.

Reported-by: Ranier Vilela <ranier.vf@gmail.com>
Author: Etsuro Fujita <etsuro.fujita@gmail.com>
Reviewed-by: Ranier Vilela <ranier.vf@gmail.com>
Discussion: https://postgr.es/m/CAEudQArgiALbV1akQpeZOgim7XP05n%3DbDP1%3DTcOYLA43nRX_vA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/21c9756db6458f859e6579a6754c78154321cb39

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 7 +++++++
1 file changed, 7 insertions(+)


pgsql-committers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: pgsql: Fix bogus grammar for a CREATE CONSTRAINT TRIGGER error
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix incompatibility with libxml2 >= 2.14