pgsql: Fix missing FSM vacuum opportunities on tables without indexes. - Mailing list pgsql-committers

From Masahiko Sawada
Subject pgsql: Fix missing FSM vacuum opportunities on tables without indexes.
Date
Msg-id E1uWqwd-004JG4-1q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix missing FSM vacuum opportunities on tables without indexes.

Commit c120550edb86 optimized the vacuuming of relations without
indexes (a.k.a. one-pass strategy) by directly marking dead item IDs
as LP_UNUSED. However, the periodic FSM vacuum was still checking if
dead item IDs had been marked as LP_DEAD when attempting to vacuum the
FSM every VACUUM_FSM_EVERY_PAGES blocks. This condition was never met
due to the optimization, resulting in missed FSM vacuum
opportunities.

This commit modifies the periodic FSM vacuum condition to use the
number of tuples deleted during HOT pruning. This count includes items
marked as either LP_UNUSED or LP_REDIRECT, both of which are expected
to result in new free space to report.

Back-patch to v17 where the vacuum optimization for tables with no
indexes was introduced.

Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/CAD21AoBL8m6B9GSzQfYxVaEgvD7-Kr3AJaS-hJPHC+avm-29zw@mail.gmail.com
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3811ca3600a31f999e4709de4a9c64c789992e14

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Masahiko Sawada
Date:
Subject: pgsql: Fix missing FSM vacuum opportunities on tables without indexes.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Reformat some node comments