pgsql: Avoid uninitialized value error in TAP tests' Cluster->psql - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Avoid uninitialized value error in TAP tests' Cluster->psql
Date
Msg-id E1uWFIK-0043Dq-1D@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid uninitialized value error in TAP tests' Cluster->psql

If the method is called in scalar context and we didn't pass in a stderr
handle, one won't be created. However, some error paths assume that it
exists, so in this case create a dummy stderr to avoid the resulting
perl error.

Per gripe from Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru> and
adapted from his patch.

Discussion: https://postgr.es/m/378eac5de4b8ecb5be7bcdf2db9d2c4d@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c3e28e9fd936b83dbb6dfb5003b6221d98f8469c

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 8 ++++++++
1 file changed, 8 insertions(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: pgflex: propagate environment to flex subprocess
Next
From: Andres Freund
Date:
Subject: pgsql: aio: Fix reference to outdated name