pgsql: Avoid bogus scans of partitions when validating FKs to partition - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Avoid bogus scans of partitions when validating FKs to partition
Date
Msg-id E1uNCMR-000JIG-22@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid bogus scans of partitions when validating FKs to partitioned tables

Validating an unvalidated foreign key that references a partitioned
table would try to queue validations for each individual partition of
the referenced table, but this is wrong: each individual partition would
not necessarily have all the referenced rows, so errors would be raised.
Avoid doing that.  The pg_constraint rows that cause this to happen are
only there to support the action triggers that implement the DELETE/
UPDATE actions of the FK, so no validating scan is necessary.

This was an oversight in commit b663b9436e75.

An equivalent oversight exists for NOT ENFORCED constraints, which is
not fixed in this commit.

Author: Amul Sul <sulamul@gmail.com>
Reported-by: Antonin Houska <ah@cybertec.at>
Reviewed-by: jian he <jian.universality@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Discussion: https://postgr.es/m/26983.1748418675@localhost

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cc733ed164c5b57fdf34d16e4cc8e9bbdc171699

Modified Files
--------------
src/backend/commands/tablecmds.c          | 51 ++++++++++++++++-------
src/test/regress/expected/foreign_key.out | 68 ++++++++++++++++++++++++-------
src/test/regress/sql/foreign_key.sql      | 29 ++++++++++---
3 files changed, 114 insertions(+), 34 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Change role names used in trigger test.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: you must own the target object to use SECURITY LABEL.