pgsql: Test restartpoints in archive recovery. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Test restartpoints in archive recovery.
Date
Msg-id E1u6Wcb-000yA6-0v@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Test restartpoints in archive recovery.

v14 commit 1f95181b44c843729caaa688f74babe9403b5850 and its v13
equivalent caused timing-dependent failures in archive recovery, at
restartpoints.  The symptom was "invalid magic number 0000 in log
segment X, offset 0", "unexpected pageaddr X in log segment Y, offset 0"
[X < Y], or an assertion failure.  Commit
3635a0a35aafd3bfa80b7a809bc6e91ccd36606a and predecessors back-patched
v15 changes to fix that.  This test reproduces the problem
probabilistically, typically in less than 1000 iterations of the test.
Hence, buildfarm and CI runs would have surfaced enough failures to get
attention within a day.

Reported-by: Arun Thirupathi <arunth@google.com>
Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e297ddcfb7d37f54567b9a9bb87ef15e0aedc0d5

Modified Files
--------------
src/test/recovery/meson.build                   |  1 +
src/test/recovery/t/045_archive_restartpoint.pl | 57 +++++++++++++++++++++++++
2 files changed, 58 insertions(+)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix issue with ORDER BY / DISTINCT aggregates and FILTER
Next
From: Noah Misch
Date:
Subject: pgsql: Comment on need to MarkBufferDirty() if omitting DELAY_CHKPT_STA